-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] 8241825: Make compressed oops and compressed class pointer… #672
Conversation
@@ -62,4 +62,6 @@ const bool CCallingConventionRequiresIntsAsLongs = true; | |||
// Define the condition to use this -XX flag. | |||
#define USE_POLL_BIT_ONLY UseSIGTRAP | |||
|
|||
#define COMPRESSED_CLASS_POINTERS_DEPENDS_ON_COMPRESSED_OOPS true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
原patch 8241825 a/src/hotspot/cpu/ppc/globalDefinitions_ppc.hpp
#define COMPRESSED_CLASS_POINTERS_DEPENDS_ON_COMPRESSED_OOPS false
这里为啥改成true了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ppc我们没有测试,就让它保持原样了
x64的build挂了,可以参考 dragonwell-project/dragonwell17@7357e1d 修复下 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…s independent(x86_64) Summary: Make UseCompressedOops and UseCompressedClassPointers independent on x86_64 Test Plan: CICD Reviewed-by: kuaiwei, yulei, lingjun Issue: dragonwell-project#669
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…s independent(x86_64)
Summary: Make UseCompressedOops and UseCompressedClassPointers independent on x86_64
Test Plan: CICD
Reviewed-by: kuaiwei, yulei, lingjun
Issue: #669